Skip to content

fix: address review feedback from PRs #21284 and #21237 (backport #21369)#21586

Merged
benesjan merged 1 commit intobackport-to-v4-next-stagingfrom
claudebox/backport-21369-v4-next
Mar 17, 2026
Merged

fix: address review feedback from PRs #21284 and #21237 (backport #21369)#21586
benesjan merged 1 commit intobackport-to-v4-next-stagingfrom
claudebox/backport-21369-v4-next

Conversation

@AztecBot
Copy link
Collaborator

Summary

Backport of #21369 to v4-next.

Changes:

  • Updated utility function error message prefix from "Calling utility functions directly..." to "Direct invocation of utility functions..." for consistency with private/public function messages
  • Updated corresponding expected_error test file

Conflict resolution

  • yarn-project/aztec/src/cli/cmds/utils/needs_recompile.ts: File does not exist on v4-next (deleted). The PR only added a comment to this file, so the change is irrelevant — skipped.
  • expected_error: v4-next uses a different error URL format ("See documentation for instructions...") vs next ("See https://docs.aztec.network/errors/6"). Applied only the prefix change from the PR, preserving v4-next's URL format.

Original author: @benesjan

ClaudeBox log: https://claudebox.work/s/4427cdaa1e7ca001?run=1

@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label Mar 16, 2026
@AztecBot AztecBot force-pushed the claudebox/backport-21369-v4-next branch from e5cb955 to 91fd2ce Compare March 16, 2026 11:56
Copy link
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff looks good

@benesjan benesjan marked this pull request as ready for review March 17, 2026 03:23
@benesjan benesjan requested a review from nventuro as a code owner March 17, 2026 03:23
@benesjan benesjan merged commit 48a4a9b into backport-to-v4-next-staging Mar 17, 2026
13 checks passed
@benesjan benesjan deleted the claudebox/backport-21369-v4-next branch March 17, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants